VS 284 Add prepare step to Quick Start #7685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RoriCremer
force-pushed
the
rc-vs-284-qc-update
branch
from
a869b61 to
e14dd90
Compare
kcibul
reviewed
Feb 18, 2022
| | ---------------- |-------------------------------------------------------------------------------------------------| | ||
| | data_project | The name of the google project containing the dataset | | ||
| | default_dataset | The name of the dataset | | ||
| | destination_cohort_table_prefix | The name of the preparation table that this step is creating | |
There was a problem hiding this comment.
Maybe add an example to the description here? e.g. a table named <destination_cohort_table_prefix>__REF_RANGES will be created just to make it clear that it's a prefix.
RoriCremer
commented
Feb 18, 2022
| | data_project | The name of the google project containing the dataset | | ||
| | default_dataset | The name of the dataset | | ||
| | destination_cohort_table_prefix | The name of the preparation table that this step is creating | | ||
| | fq_sample_mapping_table | The fully qualified table name of the samples to extract (e.g. <project>.<dataset>.sample_info) | |
There was a problem hiding this comment.
hmm looks like it's optional in the WDL---which would make sense since it looks like it's pretty easy for gatk or the WDL to figure out this table name...
RoriCremer
force-pushed
the
rc-vs-284-qc-update
branch
from
e14dd90 to
8ec444f
Compare
This was referenced Mar 17, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this is all I need to add?