-
Notifications
You must be signed in to change notification settings - Fork 596
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added additional workflow and README updates for Quickstart [VS-183] #7463
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good but a little confused about removing that external sample id field
|
||
These are the required parameters which must be supplied to the workflow: | ||
|
||
| Parameter | Description | | ||
| ----------------- | ----------- | | ||
| project_id | The name of the google project containing the dataset | | ||
| dataset_name | The name of the dataset you created above | | ||
| external\_sample_names | Use `this.samples.sample_id` | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't this a required parameter to the workflow?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is, but when the user clones and then runs the workflow, the saved inputs should be populated automatically. I thought that was how it was set up before, so I was going along with that method, but I'd also be happy to put that in.
Closes https://broadworkbench.atlassian.net/browse/VS-183