update import for is_loaded #7416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or __UNPARTITIONED__ so it doesn't error out in int conversion
rsasch
suggested changes
Aug 16, 2021
There was a problem hiding this comment.
With the "is_loaded" column added to the schema, I ran into errors trying to ingest data, I think because the number of columns doesn't match up. Currently, that column is created here: https://github.com/broadinstitute/gatk/blob/ah_var_store/scripts/variantstore/wdl/GvsImportGenomes.wdl#L885 so it doesn't need to be in the original schema.
|
I moved creating the sample_info table to the GvsAssignIds.wdl so the GvsImportGenomes is no longer updating the sample_info table. I removed the add column because this fails on repeated runs of the GvsImportGenomes wdl (it only needs to be added once, so it makes sense to actually do that on table creation) |
This was referenced Mar 17, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add "id_loaded" column to schema
add "partition_id != 'UNPARTITIONED'" to query so we don't get int conversion error