added support for loading QUALapprox into VET #7101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| public String getColumnValue(final VariantContext variant) { | ||
| String out = getAttribute(variant, "QUALapprox", null); | ||
| if (out == null) { | ||
| throw new UserException("Cannot be missing required value for QUALapprox at site: " + variant.toString()); |
There was a problem hiding this comment.
neat. out of curiosity - is there documentation somewhere of the input requirements? is QUALapprox always present in gvcfs? also thinking more broadly about the method of reblocking required, etc.
There was a problem hiding this comment.
It's more that we know the downstream tools require this annotation, but it's produced by GATK Reblocking (which is the real prerequisite).
mmorgantaylor
approved these changes
Feb 24, 2021
kcibul
added a commit
that referenced
this pull request
Mar 9, 2021
mmorgantaylor
pushed a commit
that referenced
this pull request
Apr 6, 2021
This was referenced Mar 17, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of resolving https://github.com/broadinstitute/dsp-spec-ops/issues/244
Loading site-level QualApprox into VET... usage will be in a different PR