Making ingest work on gvcfs without allele specific annotations #6934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meganshand
force-pushed
the
ms_asingest
branch
from
ff0868c to
c4a740a
Compare
ahaessly
approved these changes
Nov 3, 2020
| if(!out.endsWith("|0.00")) { | ||
| logger.warn("Expected AS_RAW_MQ value to end in |0.00. value is: " + out + " for variant " + variant.toString()); | ||
| } | ||
| out = out.substring(0, out.length() - 5); |
There was a problem hiding this comment.
we need to replace the line above with this since we might have actual data in the last field:
out = out.substring(0, out.lastIndexOf("|"));
| String out = getAttribute(variant, GATKVCFConstants.AS_RAW_READ_POS_RANK_SUM_KEY, ""); | ||
| if (out.contentEquals("||") || out.contentEquals("|||") ) { | ||
| String out = getAttribute(variant, GATKVCFConstants.AS_RAW_READ_POS_RANK_SUM_KEY, null); | ||
| if (out == null || out.contentEquals("||") || out.contentEquals("|||") ) { | ||
| out = " "; // TODO is this better than null? |
There was a problem hiding this comment.
I didn't notice before that we were setting this to a space (here and for MQRankSum). for PTG and PID we use the empty string if we don't have a value. can we change these to the empty string too?
ahaessly
reviewed
Nov 3, 2020
| String[] outValues = out.split("\\|"); | ||
| out = Arrays | ||
| .stream(outValues) | ||
| .map(val -> val.endsWith(".00") ? val.substring(0, val.length() - 3) : val) |
There was a problem hiding this comment.
formatting nit - the 5 lines above should be tabbed out one level
kcibul
pushed a commit
that referenced
this pull request
Jan 29, 2021
kcibul
pushed a commit
that referenced
this pull request
Feb 1, 2021
Marianie-Alphonse
pushed a commit
that referenced
this pull request
Feb 16, 2021
kcibul
pushed a commit
that referenced
this pull request
Mar 9, 2021
mmorgantaylor
pushed a commit
that referenced
this pull request
Apr 6, 2021
This was referenced Mar 17, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a first pass, but at the very least hopefully won't blow up on older data (that has been reblocked). I'm currently leaving the raw rank sum values blank if they don't exist in the input. This means the data will look smaller than a real allele specific gvcf, but I didn't know how to fake those values from the data we have in the non-allele specific gvcf.