-
Notifications
You must be signed in to change notification settings - Fork 596
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moving and testing ingest scripts from variantstore #6881
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a couple of questions. merge whenever
cpu: 2 | ||
} | ||
output { | ||
File metadata_tsv = glob("sample_*.tsv")[0] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i changed the name of the file from metadata_.tsv to sample_.tsv. it might make it more clear to update this output param. (if you do, also change it in the inputs to LoadArrays)
Int table_id | ||
File raw_schema | ||
File sample_list_schema | ||
String load = "false" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is false the right default?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll change it to true.
LOAD=true | ||
else | ||
LOAD=false | ||
fi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
when do you not want to load?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My thought was that if we end up using Google Data Transfer we need a script that will create the tables but not actually load the data. Ideally we'd add the generation of the Transfers to this script too, but I didn't get around to doing that.
Now that I look at this though, I think the code for this script is all contained within the WDL and I shouldn't have committed this extra file. I'll add a comment about the Google Data Transfer to the WDL and delete this bash script.
* Copying files over from variantstore * some changes * forgot to turn the test back on * fixing test * addressing comments
* Copying files over from variantstore * some changes * forgot to turn the test back on * fixing test * addressing comments
* Copying files over from variantstore * some changes * forgot to turn the test back on * fixing test * addressing comments
* Copying files over from variantstore * some changes * forgot to turn the test back on * fixing test * addressing comments
* Copying files over from variantstore * some changes * forgot to turn the test back on * fixing test * addressing comments
* Copying files over from variantstore * some changes * forgot to turn the test back on * fixing test * addressing comments
No description provided.