ah update array extract tool #6827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meganshand
reviewed
Sep 17, 2020
| @@ -98,6 +98,12 @@ | |||
| ) | |||
| private String cohortTable = null; | |||
|
|
|||
| @Argument( | |||
| fullName = "gt-only", | |||
| doc = "If true, only get the genotype info", | |||
There was a problem hiding this comment.
Can you say in the doc here what is excluded since it's not that many fields (NORMX, NORMY, LLR, and BAF)
| genotypeAlleles.add(alleles.get(2)); | ||
| break; | ||
| case MISSING: | ||
| default: |
There was a problem hiding this comment.
Do you need this default here?
| builder.id(probeInfo.name); | ||
|
|
||
| List<Allele> alleles = createAllelesFromProbeInfo(probeInfo); | ||
| Allele ref = Allele.create(probeInfo.ref, true); |
There was a problem hiding this comment.
Is the diff just being weird or should the code below be deleted since it was moved to createAllelesFromProbeInfo?
There was a problem hiding this comment.
oh, i need to change createAlleles... back to just new ArrayList.
this version of the methods need to know alleleA and alleleB so there is some duplicate code while we are supporting the legacy mode.
meganshand
pushed a commit
that referenced
this pull request
Oct 6, 2020
* remove compressed data, change GT to single char
kcibul
pushed a commit
that referenced
this pull request
Jan 29, 2021
* remove compressed data, change GT to single char
kcibul
pushed a commit
that referenced
this pull request
Feb 1, 2021
* remove compressed data, change GT to single char
Marianie-Alphonse
pushed a commit
that referenced
this pull request
Feb 16, 2021
* remove compressed data, change GT to single char
kcibul
pushed a commit
that referenced
this pull request
Mar 9, 2021
* remove compressed data, change GT to single char
mmorgantaylor
pushed a commit
that referenced
this pull request
Apr 6, 2021
* remove compressed data, change GT to single char
This was referenced Mar 17, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remove compressed data, change GT to single char