ValidateVariants exception message improvement #6076
Conversation
|
Thanks for fixing the message! I couldn't track down the original |
ldgauthier
force-pushed
the
ldg_validateVariantsBug
branch
from
3321d15 to
84b9e10
Compare
| @@ -160,6 +160,15 @@ public void testBadChrCount1() throws IOException { | |||
| ); | |||
|
|
|||
| spec.executeTest("test bad chr counts #1", this); | |||
|
|
|||
| //test with no reference and no validations specified | |||
| IntegrationTestSpec spec2 = new IntegrationTestSpec( | |||
There was a problem hiding this comment.
Could go through all of the tests and make these final, but I'll leave it up to you.
There was a problem hiding this comment.
Adam put these tests in and he was missing finals???
I did the two in the test I modified, but I don't like having my git blame all over the place if I didn't substantively modify the tests.
|
@samuelklee I bet you were right about Jonathan's latest fix, but the error message did still need a little polish. |
There was a problem hiding this comment.
Whoops, guess I never approved this? Apologies, @ldgauthier!
I added a test according to #4642 , but can't reproduce the error. The user also noted that the error message was badly formed, which is true because it ended with a colon. Now it looks like:
"Input src/test/resources/org/broadinstitute/hellbender/tools/walkers/ValidateVariants/validationExampleBad.vcf fails strict validation of type CHR_COUNTS: the Allele Count (AC) tag is incorrect for the record at position 1:985447, 1 vs. 2"