-
Notifications
You must be signed in to change notification settings - Fork 597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multi-Allelic Variant Funcotation Filtration #5588
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5588 +/- ##
===============================================
- Coverage 87.041% 87.012% -0.029%
- Complexity 31490 31795 +305
===============================================
Files 1924 1940 +16
Lines 145189 146481 +1292
Branches 16082 16198 +116
===============================================
+ Hits 126374 127456 +1082
- Misses 12958 13108 +150
- Partials 5857 5917 +60
|
@jonn-smith Looks like this is for you, or to delegate as you please. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
I have a minor request and a question.
src/main/java/org/broadinstitute/hellbender/tools/funcotator/FilterFuncotations.java
Show resolved
Hide resolved
src/main/java/org/broadinstitute/hellbender/tools/funcotator/FilterFuncotations.java
Show resolved
Hide resolved
...n/java/org/broadinstitute/hellbender/tools/funcotator/filtrationRules/FuncotationFilter.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Since Funcotation annotation can be multi-allelic, the filtration code needs to not assume that all Funcotated variants will have only one key of each funcotation.