Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi-Allelic Variant Funcotation Filtration #5588

Merged
merged 4 commits into from
Feb 15, 2019

Conversation

tlangs
Copy link
Contributor

@tlangs tlangs commented Jan 17, 2019

Since Funcotation annotation can be multi-allelic, the filtration code needs to not assume that all Funcotated variants will have only one key of each funcotation.

@codecov-io
Copy link

codecov-io commented Jan 17, 2019

Codecov Report

Merging #5588 into master will decrease coverage by 0.029%.
The diff coverage is 90.244%.

@@               Coverage Diff               @@
##              master     #5588       +/-   ##
===============================================
- Coverage     87.041%   87.012%   -0.029%     
- Complexity     31490     31795      +305     
===============================================
  Files           1924      1940       +16     
  Lines         145189    146481     +1292     
  Branches       16082     16198      +116     
===============================================
+ Hits          126374    127456     +1082     
- Misses         12958     13108      +150     
- Partials        5857      5917       +60
Impacted Files Coverage Δ Complexity Δ
...er/tools/funcotator/filtrationRules/LofFilter.java 100% <100%> (ø) 5 <2> (ø) ⬇️
...ools/funcotator/filtrationRules/ClinVarFilter.java 100% <100%> (ø) 7 <5> (+2) ⬆️
...er/tools/funcotator/filtrationRules/LmmFilter.java 100% <100%> (ø) 3 <2> (+1) ⬆️
...ellbender/tools/funcotator/FilterFuncotations.java 93.103% <100%> (ø) 18 <1> (ø) ⬇️
.../funcotator/filtrationRules/FuncotationFilter.java 100% <100%> (ø) 8 <4> (+4) ⬆️
...r/filtrationRules/FilterFuncotationsExacUtils.java 81.818% <80.952%> (-0.535%) 12 <7> (+5)
...walkers/genotyper/afcalc/AFCalculatorProvider.java 22.222% <0%> (-44.444%) 2% <0%> (-2%)
...notyper/afcalc/ConcurrentAFCalculatorProvider.java 50% <0%> (-33.333%) 1% <0%> (-1%)
...nder/utils/downsampling/PositionalDownsampler.java 88.462% <0%> (-11.538%) 22% <0%> (+1%)
...er/engine/spark/datasources/VariantsSparkSink.java 78.125% <0%> (-11.53%) 8% <0%> (-1%)
... and 138 more

@lbergelson
Copy link
Member

@jonn-smith Looks like this is for you, or to delegate as you please.

Copy link
Collaborator

@jonn-smith jonn-smith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

I have a minor request and a question.

Copy link
Collaborator

@jonn-smith jonn-smith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@jonn-smith jonn-smith merged commit 743f2e8 into master Feb 15, 2019
@jonn-smith jonn-smith deleted the tl_mutli_allel_variant_func_filtration branch February 15, 2019 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants