-
Notifications
You must be signed in to change notification settings - Fork 597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add description getter to GATKReportTable #5443
Add description getter to GATKReportTable #5443
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5443 +/- ##
===============================================
- Coverage 87.007% 86.798% -0.209%
+ Complexity 31175 31089 -86
===============================================
Files 1908 1908
Lines 144007 144008 +1
Branches 15927 15927
===============================================
- Hits 125296 124996 -300
- Misses 12954 13286 +332
+ Partials 5757 5726 -31
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Simple enough, but two minor changes requested.
@@ -664,4 +664,8 @@ public boolean equals(final GATKReportTable table) { | |||
return underlyingData; | |||
} | |||
} | |||
|
|||
public String getTableDescription() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please move this so its up next to the other getters, and add javadoc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done. since we're adding javadoc to one getter, i added it to all the others (which didnt have it). are you OK squashing when merging?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good - thx for the javadoc!
This PR is a simple addition to add GATKReportTable.getDescription(), to allow other classes to get the value of description.