Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Now can create annotations for symbollic alleles and masked alleles. #5406

Merged
merged 2 commits into from
Nov 14, 2018

Conversation

jonn-smith
Copy link
Collaborator

  • Updated data sources to include variant sites for symbolic alleles.
  • Fixed tests to be correct for new logic.
  • Now has tests for symbollic alternate alleles and masked alleles.

Fixes #5402

- Updated data sources to include variant sites for symbolic alleles.
- Fixed tests to be correct for new logic.
- Now has tests for symbollic alternate alleles and masked alleles.

Fixes #5402
@codecov-io
Copy link

codecov-io commented Nov 14, 2018

Codecov Report

Merging #5406 into master will increase coverage by 0.004%.
The diff coverage is 92.553%.

@@               Coverage Diff               @@
##              master     #5406       +/-   ##
===============================================
+ Coverage     87.027%   87.031%   +0.004%     
- Complexity     30440     30456       +16     
===============================================
  Files           1852      1853        +1     
  Lines         140936    140995       +59     
  Branches       15508     15518       +10     
===============================================
+ Hits          122653    122710       +57     
  Misses         12644     12644               
- Partials        5639      5641        +2
Impacted Files Coverage Δ Complexity Δ
...nder/tools/funcotator/FuncotatorUtilsUnitTest.java 92.577% <ø> (ø) 86 <0> (ø) ⬇️
...llbender/tools/funcotator/FuncotatorConstants.java 75% <100%> (+8.333%) 1 <1> (ø) ⬇️
...nder/tools/funcotator/FuncotatorTestConstants.java 97.826% <100%> (+0.099%) 1 <0> (ø) ⬇️
...ources/gencode/DataProviderForTroubleVariants.java 90.909% <90.909%> (ø) 1 <1> (?)
...dataSources/gencode/GencodeFuncotationFactory.java 87.304% <91.304%> (+0.472%) 207 <14> (+12) ⬆️
...ces/gencode/GencodeFuncotationFactoryUnitTest.java 91.815% <94.118%> (+0.193%) 63 <0> (+3) ⬆️
...oadinstitute/hellbender/utils/gcs/BucketUtils.java 81.098% <0%> (-0.61%) 42% <0%> (ø)

Copy link
Contributor

@LeeTL1220 LeeTL1220 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor stuff. Feel free to address and merge...

@jonn-smith jonn-smith merged commit 864b180 into master Nov 14, 2018
@jonn-smith jonn-smith deleted the jts_symbollic_allele_fix_5402 branch November 14, 2018 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants