-
Notifications
You must be signed in to change notification settings - Fork 597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add jitpack support for SNAPSHOTS #5056
Add jitpack support for SNAPSHOTS #5056
Conversation
@lbergelson - maybe you can have a look, as you commented in the original issue. As the commit isn't in the repo yet, I cannot test if it is working here. But here are the logs for the commit in the repo where I did the change: https://jitpack.io/com/github/bioinformagik/gatk/6270fa279/build.log |
Codecov Report
@@ Coverage Diff @@
## master #5056 +/- ##
============================================
+ Coverage 86.35% 86.37% +0.02%
- Complexity 28824 29156 +332
============================================
Files 1791 1814 +23
Lines 133601 135364 +1763
Branches 14920 15042 +122
============================================
+ Hits 115364 116914 +1550
- Misses 12834 12996 +162
- Partials 5403 5454 +51
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@magicDGS I have a few suggestions. Have you tested that this works or is that impossible until it's merged?
scripts/prepareJitpackEnvironment.sh
Outdated
@@ -0,0 +1,11 @@ | |||
#!/bin/bash | |||
|
|||
GIT_LFS_VERSION="1.2.1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd use a more recent version, maybe probably 2.5.1 since it's the most recent.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
scripts/prepareJitpackEnvironment.sh
Outdated
|
||
echo "Fetching LFS files." | ||
$GIT_LFS install | ||
$GIT_LFS pull |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should use git lfs pull --include src/main/resources/large
which only downloads the ~50mb of files required to build gatk rather than the 3+ gb of test resources required to test it as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
@@ -0,0 +1,4 @@ | |||
jdk: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If it's possible to add comments to this yaml, could you add one explaining what it is for people who aren't familliar with jitpack.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will first push the next changes to test the build (can also be tested from the fork, as this branch is not part of this repo) and then try to add the comments (jitpack have very bad documentation for the yml, I extracted the info from https://jitpack.io/docs/BUILDING/#custom-commands)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done (only adding a purpose comment) - let me know if you would like more info
@@ -0,0 +1,11 @@ | |||
#!/bin/bash |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add a comment to this file explaining what it is for people who don't know what jitpack is.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
@lbergelson - the last commit works. Check the logs and artifacts in this folder: https://jitpack.io/com/github/bioinformagik/gatk/336d389ecc605f4138226dddda41981f78278e09 |
Back to you @lbergelson - also, do you think that this will still work after #5112? |
@magicDGS It looks like jitpack runs |
@magicDGS Thanks for doing this. |
Closes #4819