Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NIO output support for multiple tools #4695

Merged
merged 1 commit into from
Apr 24, 2018
Merged

NIO output support for multiple tools #4695

merged 1 commit into from
Apr 24, 2018

Conversation

jean-philippe-martin
Copy link
Contributor

These tools can now write bam files to Google Buckets: ClipReads, LeftAlignIndels, RevertBaseQualityScores, UnmarkDuplicates, SplitNCigarReads

ClipReads, LeftAlignIndels, RevertBaseQualityScores, UnmarkDuplicates,
SplitNCigarReds
@codecov-io
Copy link

Codecov Report

Merging #4695 into master will decrease coverage by 0.008%.
The diff coverage is 80%.

@@               Coverage Diff               @@
##              master     #4695       +/-   ##
===============================================
- Coverage     79.855%   79.847%   -0.008%     
+ Complexity     17337     17334        -3     
===============================================
  Files           1074      1074               
  Lines          62938     62938               
  Branches       10186     10186               
===============================================
- Hits           50259     50254        -5     
- Misses          8700      8704        +4     
- Partials        3979      3980        +1
Impacted Files Coverage Δ Complexity Δ
...oadinstitute/hellbender/tools/LeftAlignIndels.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...ute/hellbender/tools/walkers/UnmarkDuplicates.java 90% <100%> (ø) 5 <1> (ø) ⬇️
...org/broadinstitute/hellbender/tools/ClipReads.java 90.385% <100%> (ø) 35 <0> (ø) ⬇️
...lbender/tools/walkers/rnaseq/SplitNCigarReads.java 87.5% <100%> (ø) 34 <0> (ø) ⬇️
...lbender/tools/walkers/RevertBaseQualityScores.java 92.857% <100%> (ø) 6 <1> (ø) ⬇️
...utils/smithwaterman/SmithWatermanIntelAligner.java 50% <0%> (-30%) 1% <0%> (-2%)
...nder/utils/runtime/StreamingProcessController.java 70.37% <0%> (-0.823%) 50% <0%> (-1%)

@jean-philippe-martin
Copy link
Contributor Author

Travis is green, this is ready for review!

Copy link
Contributor

@droazen droazen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 looks good

@droazen droazen merged commit 0975d9b into master Apr 24, 2018
@droazen droazen deleted the jp_more_nio_output branch April 24, 2018 18:45
@jean-philippe-martin
Copy link
Contributor Author

Awesome, thank you!

cwhelan pushed a commit to cwhelan/gatk-linked-reads that referenced this pull request May 25, 2018
ClipReads, LeftAlignIndels, RevertBaseQualityScores, UnmarkDuplicates,
SplitNCigarReds
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants