Automatically schedule temporary resource files for delete on exit. #4616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
droazen
reviewed
Apr 9, 2018
| try { | ||
| File tempLibSourceDir = IOUtils.tempDir("RlibSources.", ""); | ||
| File tempLibInstallationDir = IOUtils.tempDir("Rlib.", ""); |
There was a problem hiding this comment.
For consistency with BaseTest.createTempDir(), I think that IOUtils.tempDir() should register the temp dir for recursive deletion on exit via IOUtils.deleteRecursivelyOnExit()
droazen
reviewed
Apr 9, 2018
| * @param targetDir target directory where the File should be written | ||
| * @return the newly created File containing the library | ||
| */ | ||
| public File writeLibrary(final File targetDir) { |
There was a problem hiding this comment.
Can you have this method register its libraryFile for deletion on exit using createTempFile(), rename the method and adjust the javadoc appropriately? You'll need to add an overload of createTempFile() that takes a directory argument.
droazen
reviewed
Apr 9, 2018
| try { | ||
| return executeScript(tempResourceFile.getAbsolutePath(), pythonProcessArgs, scriptArgs); | ||
| } finally { | ||
| FileUtils.deleteQuietly(tempResourceFile); |
There was a problem hiding this comment.
Might want to consider keeping this -- it doesn't hurt to delete early when possible, despite the delete on exits.
cmnbroad
force-pushed
the
cn_delete_temp_resources
branch
from
5da784d to
1a33c3f
Compare
cmnbroad
force-pushed
the
cn_delete_temp_resources
branch
from
1a33c3f to
99d93e8
Compare
Codecov Report
@@ Coverage Diff @@
## master #4616 +/- ##
===============================================
+ Coverage 80.131% 80.333% +0.202%
- Complexity 17488 17762 +274
===============================================
Files 1085 1087 +2
Lines 63245 64310 +1065
Branches 10200 10533 +333
===============================================
+ Hits 50679 51662 +983
- Misses 8579 8603 +24
- Partials 3987 4045 +58
|
droazen
approved these changes
Jun 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4577.