Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement/port ReadTransformer and ReadFilter system - enable by request #6

Closed
akiezun opened this issue Dec 10, 2014 · 5 comments
Closed
Labels
Milestone

Comments

@akiezun
Copy link
Contributor

akiezun commented Dec 10, 2014

ReadTransformer system needs to be available to hellbender tools. The mechanism of how it gets enabled needs to be coordinated with ReadFilters (issue #5 )

@akiezun
Copy link
Contributor Author

akiezun commented Dec 10, 2014

For now, this request will be treated together in this issue. We may split it later.

@vdauwera - i moved it here because it's about ReadTransformers

https://www.pivotaltracker.com/story/show/70281952

ReadTransformers should be able to be added by the command line like
filters. Currently the only way to include or add a new readTransformer is
by adding a new argument to the GATK engine, and there is no way to run
only specific transformer by a walker.
When that will be done, there are readTransformers that are currently
written as filter (for example: ReassignMappingQuality) that should be
refactor to readTransformers.
Also it will be good to put all the ReadTransformers together (like the
filters).

@akiezun akiezun changed the title Implement/port ReadTransformer system - enable by request Implement/port ReadTransformer and ReadFilter system - enable by request Dec 10, 2014
@akiezun
Copy link
Contributor Author

akiezun commented Dec 10, 2014

Merged this with ReadTransformers - there should be just one set of 'preprocessors'

@akiezun akiezun added the Engine label Dec 11, 2014
@akiezun akiezun added this to the Aye-aye milestone Dec 15, 2014
@akiezun akiezun assigned kshakir and akiezun and unassigned kshakir Dec 15, 2014
@akiezun
Copy link
Contributor Author

akiezun commented Dec 19, 2014

i'll grab this

@akiezun akiezun removed their assignment Jan 13, 2015
@droazen
Copy link
Contributor

droazen commented Jan 13, 2015

Issues that need to be addressed as part of this ticket:

  • support for arguments defined in filter classes
  • PluginManager -- to port or not to port?
  • performance issues with searching the classpath
  • separating out the readmetrics code from the code that applies filters

@droazen droazen modified the milestones: BlobFish, Aye-aye Jan 13, 2015
@akiezun akiezun modified the milestones: Aye-aye, BlobFish Feb 25, 2015
@akiezun
Copy link
Contributor Author

akiezun commented Feb 25, 2015

done for AyeAye as part of BQSR

@akiezun akiezun closed this as completed Feb 25, 2015
RoriCremer added a commit that referenced this issue Jul 29, 2021
)

* add NoNullRequiredFields task

* call NoNullRequiredFields

* add PrimaryKey task

* call PrimaryKey and reorder calls

* remove warp stuff

* rename w schema convention
This was referenced Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants