Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Funcotator is only annotating with locatable funcotation factories #5773

Closed
jonn-smith opened this issue Mar 7, 2019 · 0 comments
Closed

Funcotator is only annotating with locatable funcotation factories #5773

jonn-smith opened this issue Mar 7, 2019 · 0 comments
Assignees
@jonn-smith
Labels
bug Funcotator PRIORITY_HIGH
Milestone
Engine-Q12019

Comments

@jonn-smith
Copy link
Collaborator

Currently Funcotator has an issue where it will only annotate with Locatable Funcotation Factories.

This is because of some logic in DataSourceFuncotationFactory around whether the featureList is compatible.
@jonn-smith jonn-smith added this to the Engine-Q12019 milestone Mar 7, 2019
@jonn-smith jonn-smith self-assigned this Mar 7, 2019
jonn-smith added a commit that referenced this issue Mar 7, 2019
@jonn-smith
Now non-locatable data sources can create funcotations again.
1c842b9 
Not sure how this happened.

Now need to make tests.

Fixes #5773
jonn-smith added a commit that referenced this issue Mar 7, 2019
@jonn-smith
Now non-locatable data sources can create funcotations again.
213e088 
Primarily the large integration tests check for the non-locatable
funcotation factories producing data.

Regenerated the expected output from large tests.

Fixes #5773
@jonn-smith jonn-smith mentioned this issue Mar 7, 2019
Merged
jonn-smith added a commit that referenced this issue Mar 8, 2019
@jonn-smith
Now non-locatable data sources can create funcotations again. (#5774)
210520b 
* Now non-locatable data sources can create funcotations again.
* Regenerated the expected output from large tests.
* Added in another specific test for non-locatable data sources.

Fixes #5773
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jonn-smith jonn-smith

Labels
bug Funcotator PRIORITY_HIGH
Projects
None yet
Milestone
Engine-Q12019
Development

No branches or pull requests
1 participant
@jonn-smith