WX-833 Turn on DRS in Cromwell on Azure, add Martha URL to config #127
Conversation
coa-helm/values.yaml
Outdated
| @@ -11,6 +11,7 @@ | |||
| disableBatchScheduling: false | |||
| dockerInDockerImageName: "" | |||
| usePreemptibleVmsOnly: false | |||
| marthaUrl: RUNTIME_PARAMETER | |||
There was a problem hiding this comment.
Nit -- can we name this drsUrl intead of marthaUrl? I think ID-team is trying to cut Leo-apps over to DRSHub. Right now Leo has a config which tells it whether to send the Martha or DRSHub url when deploying apps (see: DataBiosphere/leonardo#2997).
There was a problem hiding this comment.
Oh! That might make things much easier. What's the timeline for this?
There was a problem hiding this comment.
So this change is just for Cromwell-as-an-app on Azure -- not sure the timeline for cutting over Cromwell-as-an-app on GCP, or Cromwell-not-as-an-app-on-GCP (but those should probably be tracked/planned separately).
There was a problem hiding this comment.
Ah, darn. Guess I do have to do work then! 😅
|
Waiting to merge until after broadinstitute/cromwell#6952, which is required to enable DRS access. |
|
Leo side of this: DataBiosphere/leonardo#3036 Needs testing. |
…helm into jgd_WX-833_azuredrs
| - name: MarthaUrl | ||
| value: {{ .Values.config.drsUrl }} | ||
| - name: CromwellDrsLocalizerImageName | ||
| value: {{ .Values.cromwell.image | replace "cromwell" "cromwell-drs-localizer" }} |
There was a problem hiding this comment.
Note that DRS resolution in TES isn't tested yet because TES is not working in the app.
No description provided.