WX-1566 Special Docker build for debugging

.github/workflows/chart_update_on_merge.yml

@@ -60,7 +60,7 @@ jobs:
       run: |
         set -e
         cd cromwell
-        sbt -Dproject.isSnapshot=false -Dproject.isRelease=false dockerBuildAndPush
+        sbt -Dproject.isSnapshot=false dockerBuildAndPush
     - name: Deploy to dev and board release train (Cromwell)
       uses: broadinstitute/repository-dispatch@master
       with:

.github/workflows/docker_build_test.yml

@@ -34,4 +34,10 @@ jobs:
         run: |
           set -e
           cd cromwell
-          sbt -Dproject.isSnapshot=false -Dproject.isRelease=false docker
+          sbt -Dproject.isSnapshot=false docker
+      # Rarely used but we really want it always working for emergencies
+      - name: Build Cromwell Debug Docker
+        run: |
+          set -e
+          cd cromwell
+          sbt -Dproject.isDebug=true docker

.github/workflows/trivy.yml

@@ -12,7 +12,6 @@ jobs:
         project:
         - cromiam
         - cromwell-drs-localizer
-        - perf
         - server
         - womtool
 

build.sbt

@@ -387,11 +387,6 @@ lazy val `cloud-nio-impl-drs` = (project in cloudNio / "cloud-nio-impl-drs")
   .dependsOn(common)
   .dependsOn(common % "test->test")
 
-lazy val perf = project
-  .withExecutableSettings("perf", dependencies = perfDependencies, pushDocker = false)
-  .dependsOn(common)
-  .dependsOn(common % "test->test")
-
 lazy val `cromwell-drs-localizer` = project
   .withExecutableSettings("cromwell-drs-localizer", drsLocalizerDependencies, drsLocalizerSettings)
   .dependsOn(`cloud-nio-impl-drs`)
@@ -453,7 +448,6 @@ lazy val root = (project in file("."))
   .aggregate(googleBatch)
   .aggregate(httpFileSystem)
   .aggregate(languageFactoryCore)
-  .aggregate(perf)
   .aggregate(server)
   .aggregate(services)
   .aggregate(sfsBackend)

docs/developers/Building.md

@@ -8,13 +8,6 @@ features or fixes, the following are required to build Cromwell from source:
 * [AdoptOpenJDK 11 HotSpot](https://adoptopenjdk.net/)
 * [Git](https://git-scm.com/)
 
-You can also use the [development image](https://github.com/broadinstitute/cromwell/tree/develop/scripts/docker-develop), and build a development container to work inside:
-
-```bash
-$ docker build -t cromwell-dev .
-$ docker run -it cromwell-dev bash
-```
-
 First start by cloning the Cromwell repository from GitHub:
 
 ```bash
@@ -35,15 +28,15 @@ Finally build the Cromwell jar:
 $ sbt assembly
 ```
 
-NOTE: This command will run for a long time the first time.  
-NOTE: Compiling will not succeed on directories encrypted with ecryptfs (ubuntu encrypted home dirs for example), due to long file paths.
-
 `sbt assembly` will build the runnable Cromwell JAR in `server/target/scala-2.13/` with a name like `cromwell-<VERSION>.jar`. It will also build a runnable Womtool JAR in `womtool/target/scala-2.13/` with a name like `womtool-<VERSION>.jar`.
 
-To build a [Docker](https://www.docker.com/) image, run:
+## Docker
 
-```bash
-$ sbt server/docker
-```
+The following Docker build configurations are supported. Most users will want Snapshot, resulting in an image like `broadinstitute/cromwell:<VERSION>-SNAP`.
 
-This will build and tag a Docker image with a name like `broadinstitute/cromwell:<VERSION>-SNAP`.
+| Command                                        | Build Type | Debug Tools | Description                          |
+|------------------------------------------------|------------|-------------|--------------------------------------|
+| `sbt server/docker`                            | Snapshot   | No          | Most common local build              |
+| `sbt -Dproject.isDebug=true server/docker`     | Debug      | Yes         | Local build with debugging/profiling |
+| `sbt -Dproject.isSnapshot=false server/docker` | Standard   | No          | Reserved for CI: commit on `develop` |
+| `sbt -Dproject.isRelease=true server/docker`   | Release    | No          | Reserved for CI: numbered release    |