Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WX-1460] WDL 1.1 Struct Literal Parsing #7391

Merged
merged 11 commits into from
Mar 29, 2024
+2,666 −1,938
Merged

[WX-1460] WDL 1.1 Struct Literal Parsing #7391

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
9740ec4
split branch, clean up, add biscayne test
THWiseman Mar 26, 2024
4c52f84
regenerate cascades parser, update cascades tests
THWiseman Mar 26, 2024
7596d85
add centaur test, run scalafmt
THWiseman Mar 27, 2024
55e0b42
centaur fixes
THWiseman Mar 27, 2024
d2067bc
assert struct literals aren't parsed in WDL 1.0
THWiseman Mar 27, 2024
d401031
fix issue with unit tests
THWiseman Mar 27, 2024
9e7b559
Fix test
jgainerdewar Mar 27, 2024
e53b14f
Use Cascades type evaluator
jgainerdewar Mar 27, 2024
9ffaf0b
Hole plugging
jgainerdewar Mar 28, 2024
8407081
Newlines
jgainerdewar Mar 28, 2024
024d626
Newline
jgainerdewar Mar 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Loading
Loading status checks…
Use Cascades type evaluator
@jgainerdewar
jgainerdewar committed Mar 27, 2024
commit e53b14f78e305a6ce4f05a1068770d8410e8ac24
1 change: 1 addition & 0 deletions ...orms/cascades/src/main/scala/wdl/transforms/cascades/linking/expression/types/types.scala
View file
Original file line number Diff line number Diff line change
@@ -29,6 +29,7 @@
case a: StringLiteral => a.evaluateType(linkedValues)(typeEvaluator)
case a: StringExpression => a.evaluateType(linkedValues)(typeEvaluator)
case a: ObjectLiteral => a.evaluateType(linkedValues)(typeEvaluator)
case a: StructLiteral => a.evaluateType(linkedValues)(typeEvaluator)

Check warning on line 32 in wdl/transforms/cascades/src/main/scala/wdl/transforms/cascades/linking/expression/types/types.scala

Codecov / codecov/patch

wdl/transforms/cascades/src/main/scala/wdl/transforms/cascades/linking/expression/types/types.scala#L32 

Added line #L32 was not covered by tests
case a: MapLiteral => a.evaluateType(linkedValues)(typeEvaluator)
case a: ArrayLiteral => a.evaluateType(linkedValues)(typeEvaluator)
case a: PairLiteral => a.evaluateType(linkedValues)(typeEvaluator)
Loading