Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WX-1282 Update failedJobs Query to use lo_get instead of INNER JOIN against pg_largeobject #7228

Merged
merged 4 commits into from
Oct 4, 2023
Merged

WX-1282 Update failedJobs Query to use lo_get instead of INNER JOIN against pg_largeobject #7228

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ec0cf8d
WX-1282 updated query to use lo_get instead of an INNER JOIN clause
JVThomas Sep 27, 2023
4c833e5
Merge branch 'develop' into WX-1282
JVThomas Sep 27, 2023
afc4102
Merge branch 'develop' into WX-1282
JVThomas Oct 2, 2023
e6107b5
Merge branch 'develop' into WX-1282
JVThomas Oct 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 5 additions & 14 deletions database/sql/src/main/scala/cromwell/database/slick/tables/MetadataEntryComponent.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -319,22 +319,14 @@ trait MetadataEntryComponent {
if(isPostgres) s"${'"'}$identifier${'"'}" else identifier
}

def dbMetadataValueColCheckName(isPostgres: Boolean): String = {
if(isPostgres) "obj.data" else "METADATA_VALUE"
def evaluateMetadataValue(isPostgres: Boolean, colName: String): String = {
if(isPostgres) s"convert_from(lo_get(${colName}::oid), 'UTF8')" else colName
}

def attemptAndIndexSelectStatement(callFqn: String, scatterIndex: String, retryAttempt: String, variablePrefix: String): String = {
s"SELECT ${callFqn}, MAX(COALESCE(${scatterIndex}, 0)) as ${variablePrefix}Scatter, MAX(COALESCE(${retryAttempt}, 0)) AS ${variablePrefix}Retry"
}

def pgObjectInnerJoinStatement(isPostgres: Boolean, metadataValColName: String): String = {
if(isPostgres) s"INNER JOIN pg_largeobject obj ON me.${metadataValColName} = cast(obj.loid as text)" else ""
}

def failedTaskGroupByClause(metadataValue: String, callFqn: String): String = {
return s"GROUP BY ${callFqn}, ${metadataValue}"
}

val workflowUuid = dbIdentifierWrapper("WORKFLOW_EXECUTION_UUID", isPostgres)
val callFqn = dbIdentifierWrapper("CALL_FQN", isPostgres)
val scatterIndex = dbIdentifierWrapper("JOB_SCATTER_INDEX", isPostgres)
Expand All @@ -358,11 +350,10 @@ trait MetadataEntryComponent {
FROM #${metadataEntry} me
INNER JOIN #${wmse} wmse
ON wmse.#${workflowUuid} = me.#${workflowUuid}
#${pgObjectInnerJoinStatement(isPostgres, metadataValue)}
WHERE (wmse.#${rootUuid} = $rootWorkflowId OR wmse.#${workflowUuid} = $rootWorkflowId)
AND (me.#${metadataKey} in ('executionStatus', 'backendStatus') AND #${dbMetadataValueColCheckName(isPostgres)} = 'Failed')
#${failedTaskGroupByClause(dbMetadataValueColCheckName(isPostgres), callFqn)}
HAVING #${dbMetadataValueColCheckName(isPostgres)} = 'Failed'
AND (me.#${metadataKey} in ('executionStatus', 'backendStatus') AND #${evaluateMetadataValue(isPostgres, metadataValue)} = 'Failed')
GROUP BY #${callFqn}, #${metadataValue}
HAVING #${evaluateMetadataValue(isPostgres, metadataValue)} = 'Failed'
) AS failedCalls
ON me.#${callFqn} = failedCalls.#${callFqn}
INNER JOIN (
Expand Down