-
Notifications
You must be signed in to change notification settings - Fork 359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WX-1174 Adjust NIO Copy functionality #7207
Merged
Merged
Changes from 4 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
66ddc78
WX-1174 added sas token assignment and token appending utility functi…
JVThomas 84afe9f
merging develop into branch
JVThomas e6bb1b7
WX-1174 copy and callCaching working locally with changes to copy fun…
JVThomas eaa10b2
Merge branch 'develop' into WX-1174-az-nio-copy
JVThomas d310ed4
Merge branch 'develop' into WX-1174-az-nio-copy
aednichols 188f5e6
Merge branch 'develop' into WX-1174-az-nio-copy
JVThomas a2b6bcf
Merge branch 'develop' into WX-1174-az-nio-copy
JVThomas a892621
Merge branch 'develop' into WX-1174-az-nio-copy
JVThomas a6d5e51
Merge branch 'develop' into WX-1174-az-nio-copy
JVThomas aea2d73
WX-1174-az-nio-copy fixed missing closing bracket from merge resolve
JVThomas File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,6 @@ | ||
<component name="ProjectRunConfigurationManager"> | ||
<configuration default="false" name="Repo template: Cromwell server TES" type="Application" factoryName="Application"> | ||
<option name="ALTERNATIVE_JRE_PATH" value="$USER_HOME$/.sdkman/candidates/java/current" /> | ||
<option name="ALTERNATIVE_JRE_PATH" value="$PROJECT_DIR$/../.sdkman/candidates/java/current" /> | ||
<envs> | ||
<env name="CROMWELL_BUILD_CENTAUR_SLICK_PROFILE" value="slick.jdbc.MySQLProfile$" /> | ||
<env name="CROMWELL_BUILD_CENTAUR_JDBC_DRIVER" value="com.mysql.cj.jdbc.Driver" /> | ||
|
@@ -16,6 +16,7 @@ | |
<option name="VM_PARAMETERS" value="-Dconfig.file=target/ci/resources/tes_application.conf" /> | ||
<method v="2"> | ||
<option name="Make" enabled="true" /> | ||
<option name="RunConfigurationTask" enabled="true" run_configuration_name="renderCiResources" run_configuration_type="SbtRunConfiguration" /> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 👏 👏 |
||
</method> | ||
</configuration> | ||
</component> |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this supposed to look like
or
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope, you just simply append the credential to the end of a Azure Storage URI
https://learn.microsoft.com/en-us/azure/storage/common/storage-sas-overview#how-a-shared-access-signature-works
The format's new to me too, I had the same exact reaction when I first saw that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, misread your comment. It's the first option so it'l look like...
https://example.com?sv=...
...where the
sv=...
portion is the Azure SAS tokenThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense, appreciate the link!