Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only mount reference disks if requested [WX-925] #7001

Merged
merged 1 commit into from
Feb 8, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,49 @@
version 1.0


workflow ReferenceDiskMountedOnlyIfRequested {
call MentionsNirvanaReference {}
output {
Boolean disk_mounted = MentionsNirvanaReference.disk_mounted
}
}


task MentionsNirvanaReference {
input {
# Tiny 116 byte reference file, certainly not worth attaching a 55 GiB Nirvana reference disk for this.
File mention =
"gs://broad-public-datasets/gvs/vat-annotations/Nirvana/3.18.1/SupplementaryAnnotation/GRCh38/MITOMAP_20200819.nsa.idx"
}
command <<<
PS4='\D{+%F %T} \w $ '
set -o nounset -o xtrace

# Debug output
lsblk

CANDIDATE_MOUNT_POINT=$(lsblk | sed -E -n 's!.*(/mnt/[a-f0-9]+).*!\1!p')

if [[ ! -z ${CANDIDATE_MOUNT_POINT} ]]; then
echo "Found unexpected mounted disk, investigating further."
find ${CANDIDATE_MOUNT_POINT} -print | tee find.out

if grep -i nirvana find.out; then
echo "Found what appears to be a Nirvana reference disk."
else
echo "Found unknown volume mounted, see 'find.out' for manifest."
fi
echo true > disk_mounted.out
else
echo false > disk_mounted.out
fi
>>>
runtime {
docker: "ubuntu:latest"
backend: "Papiv2-Reference-Disk-Localization"
}
output {
Boolean disk_mounted = read_boolean("disk_mounted.out")
File? find_out = "find.out"
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
name: reference_disk_mounted_only_if_requested_false
testFormat: workflowsuccess
backends: [Papiv2-Reference-Disk-Localization]

files {
workflow: reference_disk/reference_disk_mounted_only_if_requested.wdl
options: reference_disk/reference_disk_test_false.options.json
}

metadata {
workflowName: ReferenceDiskMountedOnlyIfRequested
status: Succeeded
"outputs.ReferenceDiskMountedOnlyIfRequested.disk_mounted": false
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
name: reference_disk_mounted_only_if_requested_true
testFormat: workflowsuccess
backends: [Papiv2-Reference-Disk-Localization]

files {
workflow: reference_disk/reference_disk_mounted_only_if_requested.wdl
options: reference_disk/reference_disk_test_true.options.json
}

metadata {
workflowName: ReferenceDiskMountedOnlyIfRequested
status: Succeeded
"outputs.ReferenceDiskMountedOnlyIfRequested.disk_mounted": true
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
name: reference_disk_mounted_only_if_requested_unspecified
testFormat: workflowsuccess
backends: [Papiv2-Reference-Disk-Localization]

files {
workflow: reference_disk/reference_disk_mounted_only_if_requested.wdl
options: reference_disk/reference_disk_test_unspecified.options.json
}

metadata {
workflowName: ReferenceDiskMountedOnlyIfRequested
status: Succeeded
"outputs.ReferenceDiskMountedOnlyIfRequested.disk_mounted": false
}
Original file line number Diff line number Diff line change
Expand Up @@ -452,7 +452,9 @@ class PipelinesApiAsyncBackendJobExecutionActor(override val standardParams: Sta

val inputFilePaths = inputOutputParameters.jobInputParameters.map(_.cloudPath.pathAsString).toSet
val referenceDisksToMount =
jesAttributes.referenceFileToDiskImageMappingOpt.map(getReferenceDisksToMount(_, inputFilePaths))
if (useReferenceDisks)
jesAttributes.referenceFileToDiskImageMappingOpt.map(getReferenceDisksToMount(_, inputFilePaths))
else None

val workflowOptions = workflowDescriptor.workflowOptions

Expand Down