Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BT-687] specify correct types #6829

Merged
merged 4 commits into from
Aug 18, 2022
Merged

[BT-687] specify correct types #6829

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
150e820
specify correct types
mspector Aug 15, 2022
f44de00
fix test with new type
mspector Aug 15, 2022
d16b216
remove type declarations in function call
mspector Aug 15, 2022
7c43f1c
remove unnecessary sas-token config
mspector Aug 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions filesystems/blob/src/main/scala/cromwell/filesystems/blob/BlobPathBuilderFactory.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,11 +23,11 @@ final case class BlobPathBuilderFactory(globalConfig: Config, instanceConfig: Co
val sasToken: String = instanceConfig.as[String]("sas-token")
val container: String = instanceConfig.as[String]("store")
val endpoint: String = instanceConfig.as[String]("endpoint")
val workspaceId: String = instanceConfig.as[String]("workspace-id")
val workspaceManagerURL: String = singletonConfig.config.as[String]("workspace-manager-url")
val workspaceId: Option[String] = instanceConfig.as[Option[String]]("workspace-id")
val workspaceManagerURL: Option[String] = singletonConfig.config.as[Option[String]]("workspace-manager-url")

val blobTokenGenerator: BlobTokenGenerator = BlobTokenGenerator.createBlobTokenGenerator(
container, endpoint, Option(workspaceId), Option(workspaceManagerURL))
container: String, endpoint: String, workspaceId: Option[String], workspaceManagerURL: Option[String])
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we would normally put type annotations here, in fact I didn't even know that was valid code! TIL.


override def withOptions(options: WorkflowOptions)(implicit as: ActorSystem, ec: ExecutionContext): Future[BlobPathBuilder] = {
Future {
Expand Down