MCKP gene iterator speedup #264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is an iterator which gives logical arrays used to index the COO sparse posterior object, for the purposes of breaking it up into "independent" chunks for MCKP estimation. (This is just achieved by having all entries for a given gene within a single chunk, since each gene is independent of every other during MCKP estimation.)
Previously, it was implemented as a generator which would
yielda logical array. The implementation was a bit clumsy.Now, it is implemented as a simple list, computed as fast as I can figure. The speedup for large posterior COO objects is at least a factor of 100. This is very important, since for large datasets it was taking quite a long time in some cases, like on the order of 10 minutes or more, it seemed.