Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move from setup.py to pyproject.toml #240

Merged
merged 2 commits into from
Oct 31, 2023
Merged

Move from setup.py to pyproject.toml #240

merged 2 commits into from
Oct 31, 2023

Conversation

sjfleming
Copy link
Member

Following PEP 621, and due to the error I was running into here #239 , this PR moves from using setup.py to pyproject.toml for python packaging of cellbender.

This has successfully been used to build and publish cellbender 0.3.0 to PyPI.

I have single sourced the version in /cellbender/VERSION.txt

  • For new versions, this file (and only this file) needs to be manually changed

Closes #239

Single source version in cellbender/VERSION.txt
@sjfleming sjfleming added the refactoring Code refactor label Aug 10, 2023
@sjfleming sjfleming requested a review from mbabadi August 10, 2023 04:58
@sjfleming sjfleming merged commit be36006 into dev Oct 31, 2023
@sjfleming sjfleming deleted the sf_pyproject_packaging branch October 31, 2023 14:48
sjfleming added a commit that referenced this pull request Oct 31, 2023
* Add WDL input to set number of retries. (#247)

* Move hash computation so that it is recomputed on retry, and now-invalid checkpoint is not loaded. (#258)

* Bug fix for WDL using MTX input (#246)

* Memory-efficient posterior generation (#263)

* Fix posterior and estimator integer overflow bugs on Windows (#259)

* Move from setup.py to pyproject.toml (#240)

* Fix bugs with report generation across platforms (#302)

---------

Co-authored-by: kshakir <[email protected]>
Co-authored-by: alecw <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Code refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants