-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
negative entries in filtered count matrix? #306
Comments
Same issue here. FYI, I'm also using the most recent version (0.3.1) |
Hi @bobermayer and @JordanCTLin thanks for reporting. Something went wrong in the update to v0.3.1! Please use v0.3.0 for now until I figure out what happened. I am deleting the v0.3.1. release now. |
Hi, As above, I used the scCustomize package to load the h5 file and create a dual-assay-object and used the CellBender_Feature_Diff() function to compare raw and cellbender counts. The results suggest that in my case, only 60 genes had the overall counts changed, of which 50 cellbender turned negative. Ly96, the most extreme case, had 590 counts, which got turned into -15082 somehow. Could it be some issue with the reading of the data or due to the new Seurat v5 object structure, or is it most likely a cell bender issue? I have put a lot of time into optimizing cellbender settings for more than 20 samples, 8 of which with v0.2.0. So if it is a cellbender issue, I guess I have to second guess all of them, or can I at least be sure that the v0.2 version should be safe? 230927_yng_Heart_230810_CBfinal.log |
Same issue in my case with version 0.3.1 using the conda environment. |
We also see this issue in both 0.3.0 and 0.3.1 where the outputs have negative counts. The same samples don't have apparent issues in v0.2. |
I am having the same issue.
|
Apologies that it has taken me a long time to come back to this very important issue. I am working on it now. I plan to release a v0.3.2 where this is fixed. v0.3.1 has been redacted and that version number will not be used. |
Hi,
I've been using this amazing tool successfully for more than three years now. two days ago I updated (
git pull && pip install
) to the most recent version (0.3.1; commit 3a4dc8), and I'm getting weird results: there are negative entries in the filtered h5 file, and the HTML report looks weird too. This happened in all the datasets I've run, so I tried again with Brain single-nuc and PBMC single-cell datasets from 10X, like sobut I'm getting the same result: there are about 0.1 and 0.3% negative entries in the filtered count matrix (loaded into R using this helper function).
Here's a plot comparing total counts pre- and post cellbender for Brain:
(adding up absolute counts results in post-cellbender results being much larger than pre-cellbender)
the HTML report also contains negative entries for
n_cellbender
orfraction_remaining
:Brain_10X_report.zip
(worryingly, Seurat doesn't even complain about negative counts and fails with cryptic errors only if you use
vars.to.regress
orTransferData
)Am I missing something? this happens with the default
mckp
estimator but also withmap
andmean
, and without or withPRmu
posterior regularization.thanks for your help!
The text was updated successfully, but these errors were encountered: