-
-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Import model via URL #517
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- HTML template markup - Basic Js file (No interactions yet) - en-us translations - pt-br translations
- Add button close to New model - importModal controller
- Add explanation about file type to upload (+ styles) - Add TO Do comment with desired behavior explanation - Add translations
Fiexd conflicts: app/i18n/languages/en.js app/i18n/languages/pt_BR.js
Sorry! my bad 😅
Fixed Conflicts: app/angular/workspace/workspace.js app/i18n/languages/en.js
- Remove field "Name" - Replace "file" with URL; - Update / Remove translations;
- Reduce opacity in order to avoid it to look like text instead of placeholder
- Add .alert to import modal -Defione styles adjustments to .alert inside modals (Global) - Loading indication iside modals (Global) - Add loading indication at Import modal
…o-app into feature/import-model
- Update copies - Add missing copies - CSS adjustments to avoid word-breakng wrongly - Update .note position in the code
miltonbsn
reviewed
Apr 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⭐⭐⭐⭐⭐
miltonbsn
approved these changes
Apr 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⭐⭐⭐⭐⭐
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Warning
This pull request can only be merged after the following merge requests are merged
Summary
Introduce import model functionality via BRMW public link functionality.
Users will be able to paste a public link of a model (Feature to be released yet) and make their own copy. of that file.
Screenshots