Docker image improvements #496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add build cache for yarn install command Remove unnecessary mkdir command
|
@all-contributors please add @Tarliton for code and infra |
|
I've put up a pull request to add @Tarliton! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes unnecessary commands in the Dockerfile such as mkdir (WORKDIR creates it if it's not there.
Adding a cache to the yarn install command will speed up builds when updating any dependency.
The final image was being build with the
datafolder created by docker-compose mongo container and the.gitfolder, increasing its size.The image size went from 1.3~GB to around 400MB.