Feature: Add JWT #389
Merged
Feature: Add JWT #389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joaomfiumari
commented
Dec 20, 2022
|
|
||
|
|
||
| user.token = jwt.sign({ id: user.userId }, SecretToken, { | ||
| expiresIn: 86400 |
joaomfiumari
commented
Dec 20, 2022
| .put("/:modelId/rename", rename) | ||
| .get("/:modelId/export", exportModel) | ||
| .post("/import", importModel); | ||
| .get("/",validateJWT, listAll) |
There was a problem hiding this comment.
let me know if this validation is not needed in any of those endpoints, or if I missed any
|
So,... I'm not the best person to review this pull request 😓 |
miltonbsn
previously approved these changes
Sep 17, 2023
There was a problem hiding this comment.
Amazing job here @joaomfiumari! I am sorry I took so long to review it.
This pull request improves drastically our session management, we really appreciate your effort.
joaomfiumari
force-pushed
the
feature/add-jwt
branch
from
249dc42 to
02b7e71
Compare
joaomfiumari
force-pushed
the
feature/add-jwt
branch
from
02b7e71 to
d79aa99
Compare
joaomfiumari
force-pushed
the
feature/add-jwt
branch
from
d79aa99 to
e2b3e43
Compare
miltonbsn
approved these changes
Sep 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
JWT: JSON Web Tokens