-
-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release/v0.1.4 #359
Merged
Merged
Release/v0.1.4 #359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Keep in mind this is a raw quick and dirty markup. The objective is help us to udnerstand how all elements work together.
…-app into feature/create-view
We're increasing sidebar width in order to better accommodate content being introduced.
- Follow pattern used in both model views - Remove related styles - .panel-wrapper was (Apparently) created to handle vertical scroll in the sidebar. properties-content already handle this.
- Add extra space at the end of each .panel-content to add some "breath" to elements - Remove unecessary display: none; used for development reasons in the past - Font-weight adjustments - Add word-break to .checkboxes label and .table-title elemetns
- Remove button look & feel - Use neutral style
- Use .old class to identify the old implementation - Remove unnecessary forced dimensions with position
- Rename .column-details-actions to .sidebar-block-actions (In favor to reuse it in other places without semantic conflicts) - Break .sidebar-block-actions in two main areas: - .actions-regular - .actions-destructive - Add styles to .br-button.destructive - Slightly change .br-button-yellow color
- Change the approach to deal space between regular and destructive actions
.column-detail is being reused in views. TO avoid confusion and use a more generic name, I'm changing it to .card-item.
Delete static file used as layout reference
What if tomorrow the .yellow class have a purple color?
- Introduce .table-preview code
- Set min-height for .query-expression-textarea
- Follow semantics and use .card-item-actions as part of .card-item :) - Fix markup at views.html
…-app into feature/create-view
Prevent link from being detached
Upgrade nodemon
Use meaningful page titles
Fix composed attribute img load
fix issue force production traffic via HTTPS
Feature: "View" creation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's Changed
Product improvements
Tech improvements