Skip to content

Commit

Permalink
Bump default timeouts (#54)
Browse files Browse the repository at this point in the history
Although in the steady state 10 second timeout is reasonable, in
practice p100 was observed to be much higher than that (if, for example,
the machine you are supposed to talk to needs to cold boot).

Given that just _one_ timeout terminates the entire process, it feels
like we can benefit from being quiet a bit more conservative here for
the time being.
  • Loading branch information
matklad authored Jun 6, 2024
1 parent 31f0e37 commit d720f9f
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions crates/brioche-core/src/registry.rs
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,9 @@ use crate::{
Brioche,
};

const GET_TIMEOUT: std::time::Duration = std::time::Duration::from_secs(10);
const CONNECT_TIMEOUT: std::time::Duration = std::time::Duration::from_secs(10);
const READ_TIMEOUT: std::time::Duration = std::time::Duration::from_secs(10);
const GET_TIMEOUT: std::time::Duration = std::time::Duration::from_secs(120);
const CONNECT_TIMEOUT: std::time::Duration = std::time::Duration::from_secs(120);
const READ_TIMEOUT: std::time::Duration = std::time::Duration::from_secs(120);

#[derive(Clone)]
pub enum RegistryClient {
Expand Down

0 comments on commit d720f9f

Please sign in to comment.