Skip to content

Commit

Permalink
[WIP] Debug Ubuntu 24.04 build errors
Browse files Browse the repository at this point in the history
  • Loading branch information
kylewlacy committed Dec 23, 2024
1 parent 1369ba1 commit 0e9530d
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 3 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ jobs:
strategy:
matrix:
runs_on:
- ubuntu-22.04
- ubuntu-24.04
- macos-14
runs-on: ${{ matrix.runs_on }}
steps:
Expand Down
6 changes: 4 additions & 2 deletions crates/brioche-core/src/sandbox/linux.rs
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ pub fn run_sandbox(exec: super::SandboxExecutionConfig) -> anyhow::Result<super:
command.pivot_root(&exec.sandbox_root, &sandbox_host_dir, true);
command.before_chroot({
let sandbox_root = exec.sandbox_root.clone();
move || {
let before_chroot = move || {
for (path, options) in &host_paths {
let path_metadata = path.metadata().map_err(|error| {
std::io::Error::new(
Expand Down Expand Up @@ -145,7 +145,9 @@ pub fn run_sandbox(exec: super::SandboxExecutionConfig) -> anyhow::Result<super:
})?;

Ok(())
}
};

move || before_chroot().inspect_err(|error| eprintln!("before_chroot error: {error}"))
});

let mut child = command
Expand Down

0 comments on commit 0e9530d

Please sign in to comment.