-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NEW Convert frontend assets to use silverstripe/webpack-config #85
NEW Convert frontend assets to use silverstripe/webpack-config #85
Conversation
3fc275c
to
07e020c
Compare
@sachajudd I've added the changes to this pull request to show the last updated date on the report, for example: I wasn't able to make the text green after updating the report because the reloading of the GridField is done with AJAX and we'd need to wait for that to complete before setting the text colour to green. The (legacy) GridField javascript API in core does have a "success callback" for GridField's I tried to add it to the initial report generation based on whether the report is rendered via AJAX, but clicking on the "Check for updates" also refreshes the report via AJAX when you first click on it (not ideal, but it is what it is for now). Are you happy to leave out the green colour and shorter text? |
07e020c
to
ed5f58b
Compare
Right, thanks for explaining. One of the AC's was to be able to attract the users attention so probably have to chat with @clarkepaul if we want to still achieve this. |
@robbieaverill P.C missed a couple of things. Could you please remove the commas and rearrange the time to be 31 May rather than May 31. Cheers. Edit - defined by user's locale so 👍 |
f320c14
to
9450442
Compare
Sweet, checked with @clarkepaul and we've logged the necessary improvements for the green text at #87 |
9450442
to
9294818
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Resolves #79
Also resolves #67