Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEP Use stable version of silverstripe/supported-modules #246

Merged

Conversation

emteknetnz
Copy link
Collaborator

Copy link
Collaborator

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, will merge when other PRs are all good to go

$task = UpdatePackageInfoTask::create();
$oldVersionProvider = Injector::inst()->get(VersionProvider::class);
try {
$task = UpdatePackageInfoTask::create();
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is to fix a long standing broken unit test when running sink with a forked framework version

The new try/finally block is to reset Injector::inst()->registerService($versionProvider, VersionProvider::class); back from the mock VersionProvider, to the original VersionProvder. Looking through the sapphire teststate code it's not immediately clear to me whether this is required or not (quite possibly it's not and it resets itself between tests), however I don't want to risk causing a regression later on in a subsequent unit test

Looking through the teststate stuff, it's not immediately clear to me whether or not resetting the

Copy link
Collaborator

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM though should probably have been two very separate commits. Doesn't matter enough to ping pong it.

@GuySartorelli GuySartorelli merged commit 2659275 into bringyourownideas:3 Oct 21, 2024
9 checks passed
@GuySartorelli GuySartorelli deleted the pulls/3/stable-sm branch October 21, 2024 00:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants