FIX Ensuring composer can write to it's cache directory #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It might be worth making this PR for SS3 first so we can merge it up through to SS4 |
|
What's the justification for adding this here? This module doesn't actually use Composer at all, just parses the lock files |
Good point. I'll double check the original cause of the issue was the fact that |
|
I'll close this and update the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #121 . This pulls and slightly modifies the logic linked in the issue. In addition to that code this patch will check that the provided
HOMEenvironment variable is also writable before blindly assuming it's okay.This fix is not compatible with the SS3 line of this module and although we're in "Security fixes only" for that line I'll still PR a SS3 fix for this as it's a fairly critical bug.