Add a "close" at beforeunload #3068
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While on a Zoom showing @jameskerr some of my #3063 debug, he spotted that the change here should be in the code and was missing. We'd briefly hoped that this might address the #3063 symptom, but alas, a loop of the repro steps shown in that issue did not improve the failure rate (79 successful test runs and 14 failed before I stopped it, to be precise.) Nevertheless, since @jameskerr seemed confident the absence of this code was an oversight, I'm proposing the change in hopes it'll help us avoid some other problem in the future.