Parameter manager events #211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jsvgoncalves Any idea why the tests aren't running anymore? |
jsvgoncalves
approved these changes
Nov 21, 2024
There was a problem hiding this comment.
Any idea why the tests aren't running anymore?
Standard behaviour on this repo, as far as I'm aware. But I ran the CI manually: https://github.com/brightway-lca/brightway2-data/actions/runs/11949161759
I'll squash and merge this.
|
Sorry, just so I understand it - does that mean you manually requested the tests to run before? Could I have triggered this as well? |
Yes, by clicking |
* `.delete()` isn't ran by the ORM layer but rather as a direct query and as such the approach with signals on `.save()` doesn't work. However, `.delete_instance()` is an ORM-layer call. This is at the expense of performance as all the entities to be deleted need to be looped over. See https://docs.peewee-orm.com/en/latest/peewee/playhouse.html#signals for more details.
jsvgoncalves
force-pushed
the
parameter_manager_events
branch
from
70f90e2 to
5470729
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Last PR for completing events for parameters