Use Snowflake IDs for nodes and edges #202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is now fixed. |
bw2data/backends/schema.py
Outdated
Comment on lines
8
to
21
| class SnowflakeIDBaseClass(Model): | ||
| id = IntegerField(primary_key=True) | ||
|
|
||
| def save(self, **kwargs): | ||
| if self.id is None: | ||
| # If the primary key column data is already present (even if the object doesn't exist in | ||
| # the database), peewee will make an `UPDATE` query. This will have no effect if there | ||
| # isn't a matching row. Need for force an `INSERT` query instead as we generate the ids | ||
| # ourselves. | ||
| # https://docs.peewee-orm.com/en/latest/peewee/models.html#id4 | ||
| self.id = next(snowflake_id_generator) | ||
| kwargs['force_insert'] = True | ||
| super().save(**kwargs) |
There was a problem hiding this comment.
Also conflicting with #174; will need to be rebased after that one is merged. We can then make SignaledDataset inherit from this one and up goes the super.
There was a problem hiding this comment.
We can then make SignaledDataset
exatamente
|
After #174 is merged:
|
This will go away as we will explicitly map functions instead of using string interpolation, see more-event-types branch. |
Update compatibility.py Remove debugging print statements Clarify some comments Improve error message Cleanup error messages Co-Authored-By: João Gonçalves <[email protected]>
bbguimaraes
approved these changes
Nov 8, 2024
jsvgoncalves
approved these changes
Nov 8, 2024
jsvgoncalves
added a commit
that referenced
this pull request
Nov 8, 2024
Use Snowflake IDs for nodes and edges
jsvgoncalves
added a commit
that referenced
this pull request
Nov 8, 2024
Use Snowflake IDs for nodes and edges
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed for distributed object creation without conflicting id values.