Skip to content
This repository has been archived by the owner on Mar 31, 2022. It is now read-only.
Merged
merged 24 commits into from
Jun 30, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
bb76053
Fix input autofill styles
daileytj Jun 22, 2021
08540cd
Use primary color in drawer header, use black[500] in light theme dra…
emclaug2 Jun 22, 2021
78bbb04
Fix MuiSwitch theme colors, remove hardcoded values in favor of theme…
daileytj Jun 22, 2021
45c2138
Add changelog entry for fixes
joebochill Jun 23, 2021
f81bd3f
Merge pull request #201 from pxblue/bug/ng-theme-tweaks
joebochill Jun 23, 2021
87c9081
Cleanup react themes
daileytj Jun 23, 2021
2aabe17
Use mix function in place of hardcoded colors
daileytj Jun 23, 2021
9504818
Remove React blue theme custom shadows
huayunh Jun 23, 2021
69f575c
Changelog
huayunh Jun 23, 2021
3fb1415
Update Changelog, bump version number
daileytj Jun 24, 2021
a48836a
Update MuiTableRow background color to use color variable instead of …
daileytj Jun 24, 2021
9a656e1
Merge pull request #202 from pxblue/feature/react-bug-squash
daileytj Jun 24, 2021
103bb65
Merge branch 'dev' into feature/remove-custom-shadows
huayunh Jun 24, 2021
42c8073
Merge changelog
huayunh Jun 24, 2021
309790c
Merge pull request #203 from pxblue/feature/remove-custom-shadows
huayunh Jun 24, 2021
c1c3e1e
Disabled state for primary accent warn buttons
emclaug2 Jun 29, 2021
db4c7c2
Update changelog
emclaug2 Jun 29, 2021
b2b3754
Run prettier
emclaug2 Jun 29, 2021
9692d24
Fix disabled dark mode colors
emclaug2 Jun 30, 2021
53b6212
Merge pull request #206 from pxblue/feature/ng-disabled-button-styles
EvanMcLaughlin-eaton Jun 30, 2021
bd11db7
Update changelog dates and versions
joebochill Jun 30, 2021
9838b98
Fix dark mode disabled button styles
emclaug2 Jun 30, 2021
4a43385
Run prettier
emclaug2 Jun 30, 2021
a622616
Merge pull request #207 from pxblue/feature/ng-disabled-button-styles
huayunh Jun 30, 2021
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions angular/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,15 @@
# Changelog

## v6.1.1 (June 30, 2021)

### Fixed

- Fixed a few color issues in the `<pxb-drawer-header>` ([#184](https://github.com/pxblue/themes/issues/184)) and `<pxb-drawer-nav-item>` ([#186](https://github.com/pxblue/themes/issues/186)).

### Changed

- Changed `mat-button` styles for disabled `primary`, `accent`, and `warn` variants.

## v6.1.0 (May 28, 2021)

### Added
Expand Down
20 changes: 19 additions & 1 deletion angular/_blueTheme.scss
Original file line number Diff line number Diff line change
Expand Up @@ -133,6 +133,10 @@
text: map-get($pxb-white, 50),
background: map-get($primary, 500),
backgroundHover: map-get($primary, 300),
disabled: (
text: map-get($primary, 200),
background: map-get($primary, 50),
),
),
);
$buttonAccent: (
Expand All @@ -149,6 +153,10 @@
text: map-get($pxb-white, 50),
background: map-get($accent, 500),
backgroundHover: map-get($accent, 300),
disabled: (
text: map-get($accent, 200),
background: map-get($accent, 50),
),
),
);
$buttonWarn: (
Expand All @@ -165,6 +173,10 @@
text: map-get($pxb-white, 50),
background: map-get($warn, 500),
backgroundHover: map-get($warn, 300),
disabled: (
text: map-get($warn, 200),
background: map-get($warn, 50),
),
),
);
$buttonDefault: (
Expand All @@ -181,6 +193,10 @@
text: map-get($pxb-black, 500),
background: map-get($pxb-white, 50),
backgroundHover: rgba(66, 78, 84, 0.05),
disabled: (
text: map-get($foreground, disabled),
background: map-get($background, disabled-button),
),
),
toggle: (
border: map-get($pxb-gray, 100),
Expand All @@ -200,7 +216,6 @@
.mat-stroked-button,
.mat-raised-button {
&.mat-button-disabled {
background-color: map-get($pxb-white, 50) !important;
color: map-get($foreground, disabled);
border: solid 1px map-get($foreground, divider);
}
Expand Down Expand Up @@ -327,6 +342,9 @@
.pxb-drawer-nav-item-active .pxb-info-list-item .pxb-info-list-item-icon-wrapper {
color: map-get($primary, 500);
}
.pxb-info-list-item .mat-list-item-content .mat-list-icon {
color: map-get($foreground, text);
}
}

/* Drawer Content */
Expand Down
25 changes: 24 additions & 1 deletion angular/_darkTheme.scss
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,10 @@
text: map-get($pxb-white, 50),
background: map-get($primary, 500),
backgroundHover: map-get($primary, 300),
disabled: (
text: map-get($pxb-black, 400),
background: rgba(map-get($pxb-black, 200), 0.24),
),
),
);
$buttonAccent: (
Expand All @@ -108,6 +112,10 @@
text: map-get($pxb-white, 50),
background: map-get($accent, 500),
backgroundHover: map-get($accent, 300),
disabled: (
text: map-get($pxb-black, 400),
background: rgba(map-get($pxb-black, 200), 0.24),
),
),
);
$buttonWarn: (
Expand All @@ -124,6 +132,10 @@
text: map-get($pxb-white, 50),
background: map-get($warn, 500),
backgroundHover: map-get($pxb-red, 300),
disabled: (
text: map-get($pxb-black, 400),
background: rgba(map-get($pxb-black, 200), 0.24),
),
),
);
$buttonDefault: (
Expand All @@ -140,6 +152,10 @@
text: map-get($pxb-white, 50),
background: map-get($pxb-black, 500),
backgroundHover: map-get($pxb-black, 300),
disabled: (
text: map-get($pxb-black, 400),
background: rgba(map-get($pxb-black, 200), 0.24),
),
),
toggle: (
border: map-get($pxb-black, 200),
Expand All @@ -156,9 +172,16 @@
),
);
@include pxb-mat-buttons($buttonPrimary, $buttonAccent, $buttonWarn, $buttonDefault);
.mat-icon-button.mat-button-disabled.mat-button-disabled {
.mat-icon-button.mat-button-disabled {
color: map-get($foreground, disabled);
}
.mat-stroked-button,
.mat-button {
&.mat-button-disabled.mat-button-disabled {
color: rgba(map-get($pxb-black, 300), 0.36);
border-color: rgba(map-get($pxb-black, 300), 0.36);
}
}

/* Tabs */
$tabText: map-get($foreground, secondary-text);
Expand Down
4 changes: 3 additions & 1 deletion angular/_pxb-component-theme.scss
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,9 @@
.pxb-drawer-nav-group .mat-list-base {
color: map-get($foreground, text);
}

.pxb-drawer-header-content.mat-toolbar {
background-color: map-get($primary, 500);
}
.pxb-drawer-nav-item-active-highlight {
background-color: map-get($primary, 500);
}
Expand Down
5 changes: 5 additions & 0 deletions angular/mixins/button.scss
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,11 @@
&:hover:not(.mat-button-disabled) {
background-color: map-deep-get($palette, fill, backgroundHover);
}
&.mat-button-disabled {
color: map-deep-get($palette, fill, disabled, text);
background-color: map-deep-get($palette, fill, disabled, background);
border: none;
}
}
@mixin filled-button-helper($primaryPalette, $accentPalette, $warnPalette, $defaultPalette) {
&.mat-primary {
Expand Down
2 changes: 1 addition & 1 deletion angular/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"name": "@pxblue/angular-themes",
"author": "PX Blue <[email protected]>",
"license": "BSD-3-Clause",
"version": "6.1.0",
"version": "6.1.1",
"description": "Angular themes for PX Blue applications",
"scripts": {
"initialize": "bash scripts/initializeSubmodule.sh",
Expand Down
10 changes: 9 additions & 1 deletion react/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,12 @@
# Change Log
# Changelog

## v6.1.0 (June 30, 2021)

### Changed

- Update auto-fill styles for MUI `<TextInput>`.
- Update styles for disabled MUI `<Switch>`.
- Light theme shadow base color changed back to pure black (`#000000`).

## v6.0.0 (March 29, 2021)

Expand Down
2 changes: 1 addition & 1 deletion react/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"name": "@pxblue/react-themes",
"author": "PX Blue <[email protected]>",
"license": "BSD-3-Clause",
"version": "6.0.0",
"version": "6.1.0",
"description": "React themes for PX Blue applications",
"main": "index.js",
"scripts": {
Expand Down
73 changes: 60 additions & 13 deletions react/src/blueDarkTheme.ts
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ export const blueDarkTheme: ThemeOptions = {
},
colorSecondary: {
color: ThemeColors.text.primary,
backgroundColor: PXBColors.black[900],
backgroundColor: ThemeColors.background.paper,
},
},

Expand Down Expand Up @@ -155,7 +155,7 @@ export const blueDarkTheme: ThemeOptions = {
},
'&$disabled': {
borderColor: Color(PXBColors.black[200]).alpha(0.36).string(),
color: Color(PXBColors.black[300]).alpha(0.36).string(),
color: ThemeColors.action.disabled,
},
},
outlinedPrimary: {
Expand All @@ -173,7 +173,7 @@ export const blueDarkTheme: ThemeOptions = {
},
'&$disabled': {
borderColor: Color(PXBColors.black[200]).alpha(0.36).string(),
color: Color(PXBColors.black[300]).alpha(0.36).string(),
color: ThemeColors.action.disabled,
},
},
contained: {
Expand All @@ -183,7 +183,7 @@ export const blueDarkTheme: ThemeOptions = {
backgroundColor: PXBColors.black[400],
},
'&$disabled': {
backgroundColor: Color(PXBColors.black[200]).alpha(0.24).string(),
backgroundColor: ThemeColors.action.disabledBackground,
color: PXBColors.black[400],
},
},
Expand All @@ -209,10 +209,10 @@ export const blueDarkTheme: ThemeOptions = {
},
text: {
'&$disabled': {
color: Color(PXBColors.black[300]).alpha(0.36).string(),
color: ThemeColors.action.disabled,
},
'&:hover': {
backgroundColor: Color(PXBColors.black[50]).alpha(0.1).string(),
backgroundColor: ThemeColors.action.hover,
},
},
textPrimary: {
Expand Down Expand Up @@ -614,19 +614,50 @@ export const blueDarkTheme: ThemeOptions = {
switchBase: {
color: ThemeColors.text.primary,
'&$checked + $track': {
opacity: 0.5,
opacity: 0.38,
},
'&$checked': {
color: ThemeColors.secondary.main,
'&$disabled': {
color: Color(ThemeColors.secondary.main).mix(Color(ThemeColors.background.paper), 0.5).string(),
},
'&$disabled + $track': {
backgroundColor: ThemeColors.secondary.main,
},
},
},
colorPrimary: {
'&$disabled': {
color: Color(PXBColors.white[50]).mix(Color(ThemeColors.background.paper), 0.5).string(),
},
'&$disabled + $track': {
backgroundColor: PXBColors.black[300],
},
'&$checked': {
color: ThemeColors.primary.main,
'&$disabled': {
color: Color(ThemeColors.primary.main).mix(Color(ThemeColors.background.paper), 0.5).string(),
},
'&$disabled + $track': {
opacity: 0.38,
backgroundColor: Color(ThemeColors.primary.main)
.mix(Color(ThemeColors.background.paper), 0.5)
.string(),
},
},
},
colorSecondary: {
'&$disabled': {
color: Color(PXBColors.white[50]).mix(Color(ThemeColors.background.paper), 0.5).string(),
},
'&$disabled + $track': {
backgroundColor: PXBColors.black[300],
},
},
track: {
backgroundColor: PXBColors.black[300],
opacity: 0.36,
opacity: 0.38,
},
checked: {},
},

// TABLE OVERRIDES
Expand All @@ -645,19 +676,21 @@ export const blueDarkTheme: ThemeOptions = {
color: ThemeColors.text.primary,
backgroundColor: PXBColors.darkBlack[300],
'&$hover:hover': {
backgroundColor: Color(PXBColors.darkBlack[300]).mix(Color(PXBColors.black[500]), 0.5).string(),
backgroundColor: Color(PXBColors.darkBlack[300]).mix(Color(MediumBlackBackground), 0.5).string(),
},
'&:nth-of-type(odd):not($selected)': {
backgroundColor: PXBColors.black[900],
backgroundColor: ThemeColors.background.paper,
'&$hover:hover': {
backgroundColor: Color(PXBColors.black[900]).mix(Color(PXBColors.black[500]), 0.5).string(),
backgroundColor: Color(ThemeColors.background.paper)
.mix(Color(MediumBlackBackground), 0.5)
.string(),
},
},
'&$selected': {
backgroundColor: Color(ThemeColors.primary.dark).alpha(0.2).string(),
'&$hover:hover': {
backgroundColor: Color(ThemeColors.primary.dark)
.mix(Color(PXBColors.black[500]), 0.5)
.mix(Color(MediumBlackBackground), 0.5)
.alpha(0.2)
.string(),
},
Expand Down Expand Up @@ -724,6 +757,10 @@ export const blueDarkTheme: ThemeOptions = {
color: PXBColors.black[300],
opacity: 0.36,
},
'&:-webkit-autofill': {
'-webkit-box-shadow': `0 0 0 100px ${ThemeColors.background.paper} inset`,
'-webkit-text-fill-color': ThemeColors.text.primary,
},
},
adornedStart: {},
adornedEnd: {},
Expand Down Expand Up @@ -779,6 +816,11 @@ export const blueDarkTheme: ThemeOptions = {
pointerEvents: 'none',
},
},
input: {
'&:-webkit-autofill': {
'-webkit-box-shadow': `0 0 0 100px ${PXBColors.black[800]} inset`,
},
},
underline: {
'&:before': {
borderBottomColor: ThemeColors.divider,
Expand Down Expand Up @@ -832,6 +874,11 @@ export const blueDarkTheme: ThemeOptions = {
borderColor: ThemeColors.secondary.dark,
},
},
input: {
'&:-webkit-autofill': {
'-webkit-box-shadow': `0 0 0 100px ${PXBColors.black[900]} inset`,
},
},
colorSecondary: {},
focused: {},
error: {},
Expand Down
Loading