Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix jseval engine262 output #48

Merged
merged 1 commit into from
Sep 7, 2020
Merged

Fix jseval engine262 output #48

merged 1 commit into from
Sep 7, 2020

Conversation

caub
Copy link
Contributor

@caub caub commented Sep 6, 2020

No description provided.

@brigand
Copy link
Owner

brigand commented Sep 6, 2020

We're only double-inspecting on the engine262 engine, so maybe we should make the others do the inspect themselves, and 'run' will always return a string? The current code doesn't look correct for n> ({ x: 1 }).

Also there's a merge conflict.

@caub caub force-pushed the fix-engine262-output branch 2 times, most recently from d2b894f to 9e6714c Compare September 7, 2020 18:00
@caub caub force-pushed the fix-engine262-output branch from 9e6714c to ead88b6 Compare September 7, 2020 18:09
@caub
Copy link
Contributor Author

caub commented Sep 7, 2020

ok ready!

@brigand brigand merged commit f36ac62 into brigand:master Sep 7, 2020
@brigand
Copy link
Owner

brigand commented Sep 7, 2020

Thanks! Deployed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brigand brigand brigand approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@caub @brigand