Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix entropy-keyword plugin to use analyze_line #1383

Merged
merged 3 commits into from
Jul 14, 2021

Conversation

nimrodkor
Copy link
Contributor

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

detect-secret's plugins require you to create a analyze_string, but this specific plugin needs to leverage the logic in the underlying plugins' analyze_line. Changed implementation accordingly.

Copy link
Collaborator

@rotemavni rotemavni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nimrodkor Great unit tests!

@nimrodkor nimrodkor merged commit c610db3 into master Jul 14, 2021
@nimrodkor nimrodkor deleted the fix_entropy_keyword_plugin branch July 14, 2021 11:29
github-actions bot pushed a commit that referenced this pull request Jul 14, 2021
Fix entropy-keyword plugin to use analyze_line
github-actions bot pushed a commit that referenced this pull request Jul 14, 2021
Fix entropy-keyword plugin to use analyze_line
github-actions bot pushed a commit that referenced this pull request Jul 14, 2021
Fix entropy-keyword plugin to use analyze_line
github-actions bot pushed a commit that referenced this pull request Jul 14, 2021
Fix entropy-keyword plugin to use analyze_line
github-actions bot pushed a commit that referenced this pull request Jul 14, 2021
Fix entropy-keyword plugin to use analyze_line
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants