Allow TYPE_USE on MagicConstant, Pattern, RegExp and Subst #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous regex only supported the typed enum usage, and didn't work when the enum was at the end. The new regex should be much more lenient on the placement and handles use of enum values when imported.
|
🤦♂️ wrong project |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix JetBrains#43 (and supersedes JetBrains#77).
The main goal of this PR is to enable documenting the code on the generic type parameters. Later this could also be integrated in IDE inspection.
After this PR and this is released a developer can document it's API this way :
Since
TYPE_USEis not available prior Java 8, the Java 5 project stripped this enum value from source. However it was missing some cases. This PR is more lenient in detecting and stripping this value.@Target({LOCAL_VARIABLE, TYPE_USE, ANNOTATION_TYPE})=>@Target({LOCAL_VARIABLE, ANNOTATION_TYPE})@Target({ElementType.LOCAL_VARIABLE, ElementType.TYPE_USE, ElementType.PARAMETER})=>@Target({ElementType.LOCAL_VARIABLE, ElementType.PARAMETER})@Target({ElementType.FIELD, ElementType.TYPE_USE})=>@Target({ElementType.FIELD, })@Target({ElementType.TYPE_USE, ElementType.FIELD})=>@Target({ ElementType.FIELD})