Safe json.RawMessage and json.Number #233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replacing Info.Generate that is public would break the API
It is defined in the std library and not easy to fake with other methods
|
I think this looks good. Nice job! If you are ready ill merge it in. I do want to play around with them a little before i do a release just to get a feel for things. But should be able to get it out soon. |
|
Great! As far as I'm concerned this is mergeable. I've been using this in a
project for the last couple of weeks and it has already been a big time
saver.
If you have questions when you start playing around with it, feel free to
reach out.
…On Thu, Apr 6, 2023 at 4:45 PM Brian Voelker ***@***.***> wrote:
I think this looks good. Nice job! If you are ready ill merge it in.
I do want to play around with them a little before i do a release just to
get a feel for things. But should be able to get it out soon.
—
Reply to this email directly, view it on GitHub
<#233 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABI5JG2ULC6D54RPU5NWE3W73JH5ANCNFSM6AAAAAAWTJKLDY>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two types in
encoding/jsonthat are special:json.RawMessageis defined as a[]byteand it is used to store unparsed JSON. When encountered in a struct, gofakeit generates a random array of bytes but that doesn't mean that it is a valid JSON, and it will fail when trying tojson.Marshalthe struct.json.Numberis defined as astringand it is used to represent numeric types in JSON. When encountered in a struct, gofakeit generates a random string that cannot be represented as a number and it will fail when trying tojson.Marshalthe struct.This PR adds support for those two types in the
encoding/jsonpackage ensuring that valid JSON values are generated by gofakeit by default and that the resulting struct can be marshalled to JSON. More precise output control is still available via struct tags.There are two commits that add stability and ensure reusing the Faker object in CSV, JSON, and XML. If you prefer that those two commits are moved to their own PR, I'm happy to extract them.
Other than that improvement to existing functionality, all the existing tests pass and no behaviour changes are introduced to already released functionality.