Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix datetime JSON bug affecting upstream proxying #43

Merged
merged 3 commits into from
Dec 26, 2022
Merged

Conversation

briantist
Copy link
Owner

@briantist briantist commented Dec 26, 2022

Fixes #42

Refactored a tiny bit to move the JSOn provider class to utilities and avoid a circular import.

@briantist briantist added the bug Something isn't working label Dec 26, 2022
@briantist briantist self-assigned this Dec 26, 2022
@codecov
Copy link

codecov bot commented Dec 26, 2022

Codecov Report

Base: 52.94% // Head: 53.00% // Increases project coverage by +0.05% 🎉

Coverage data is based on head (35c3130) compared to base (a1d5d27).
Patch coverage: 84.61% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #43      +/-   ##
==========================================
+ Coverage   52.94%   53.00%   +0.05%     
==========================================
  Files          22       22              
  Lines         901      900       -1     
==========================================
  Hits          477      477              
+ Misses        424      423       -1     
Impacted Files Coverage Δ
galactory/upstream.py 24.41% <50.00%> (+0.14%) ⬆️
galactory/utilities.py 45.57% <90.00%> (+2.41%) ⬆️
galactory/__init__.py 39.39% <100.00%> (-5.21%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@briantist briantist merged commit a6537f8 into main Dec 26, 2022
@briantist briantist deleted the bug/datetimejson branch December 26, 2022 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upstream proxying is broken after JSON encoder change
1 participant