Improvement

[wilsonge]

Removes code and prevents the double control-group stuff.

However comes with different issues on the permissions fields:

1. Your PR is missing if there's more than 1 field in the permissions fieldset.
2. Also in your current PR (but more unlikely practical use case) we've removed the ability to have a showon based on the permissions field (it technically existed before)

My PR has the issue that it fixes that but effectively reintroduces the controls class which means the permissions field is shifted left. So I gave it it's own class revert-permissions and overriding the margin-left. Not convinced it's amazing but it works :/

[brianteeman]

Not convinced it's amazing but it works :/

That was my view of my own code

Your PR is missing if there's more than 1 field in the permissions fieldset.

Can you give me an example of where we have that

[wilsonge]

Nothing I'm aware of in core. It seems relatively unlikely because we'd always be hiding the label. But before we did handle it and now we don't

[brianteeman]

Thanks @wilsonge