Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposed fixes for the new privacyconsent plugin #73

Merged
merged 4 commits into from
Apr 16, 2018

Conversation

zero-24
Copy link

@zero-24 zero-24 commented Apr 15, 2018

joomla#20051

Summary of Changes

  • use the joomla standard for naming strings
  • use correct since
  • joomla default ini file headers
  • propse some code fixes
  • use use :P

Testing Instructions

Apply the changes and test the plugin

Expected result

all should still work as expected

Actual result

Some things are not going the way we usually use in the cms ;)

Documentation Changes Required

None.

cc @brianteeman :)

@brianteeman brianteeman merged commit 1b3daae into brianteeman:privacy Apr 16, 2018
@sandewt
Copy link

sandewt commented Apr 16, 2018

File privacyconsent.php, rule 19

class PlgUserPrivacyconsent extends JPlugin
{

Why not?

class PlgUserPrivacyConsent extends JPlugin
{

Consent starting with an uppercase.

@brianteeman
Copy link
Owner

@sandewt I dont know. Joomla appears to use both conventions

@zero-24 zero-24 deleted the privacy_fix1 branch April 16, 2018 14:25
@zero-24
Copy link
Author

zero-24 commented Apr 16, 2018

Thanks @brianteeman

brianteeman pushed a commit that referenced this pull request May 19, 2018
brianteeman pushed a commit that referenced this pull request Aug 15, 2019
Edit Form: Title and alias in a line
brianteeman pushed a commit that referenced this pull request May 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants