Use rustup on AppVeyor #703
Conversation
| @@ -11,7 +11,7 @@ platform: | |||
| environment: | |||
| matrix: | |||
| - TOOLCHAIN_VERSION: 14.0 | |||
| RUST: 1.26.0 | |||
| RUST: stable | |||
There was a problem hiding this comment.
Capitalize AppVeyor in the commit message.
Reorder this commit to come after the switch to rustup.
Include the text "I agree to license my contributions to each file under the terms given at the top of each file I changed." in each commit as described in the Contributing section of the README.
| mkdir build | ||
| powershell -Command "(New-Object Net.WebClient).DownloadFile('%RUST_URL%', 'build\rust-%RUST%-%TARGET_ARCH%-pc-windows-msvc.msi')" | ||
| set RUSTUP_URL=https://win.rustup.rs/%TARGET_ARCH% |
There was a problem hiding this comment.
Capitalize AppVeyor correctly in the commit message and add the "I agree to license my contributions to each file under the terms given at the top of each file I changed." to each commit.
| @@ -50,7 +50,7 @@ set TARGET=%TARGET_ARCH%-pc-windows-msvc | |||
| %RUSTUP_EXE% -y --default-host %TARGET% --default-toolchain %RUST% | |||
| if %ERRORLEVEL% NEQ 0 exit 1 | |||
|
|
|||
| set PATH="C:\Users\appveyor\.cargo\bin";%cd%\windows_build_tools;%PATH% | |||
| set PATH=%USERPROFILE%\.cargo\bin;%cd%\windows_build_tools;%PATH% | |||
There was a problem hiding this comment.
This seems reasonable to me.
The first line of the commit should mention AppVeyor and should end in a period.
The commit message should end with the contribution statement from the README.
The commit messages should be wrapped to ~72 characters.
ecstatic-morse
force-pushed
the
appveyor-rustup
branch
2 times, most recently
from
f8e9fb5 to
47820f4
Compare
I agree to license my contributions to each file under the terms given at the top of each file I changed.
I agree to license my contributions to each file under the terms given at the top of each file I changed.
I agree to license my contributions to each file under the terms given at the top of each file I changed.
ecstatic-morse
force-pushed
the
appveyor-rustup
branch
from
47820f4 to
d8bffeb
Compare
|
I made the requisite changes to the commit messages. |
|
Thanks for this! Looks great! |
Use rustup to install rust on AppVeyor.
Unfortunately rustup always installs rust's documentation, so this may slow down CI builds on Windows.
I agree to license my contributions to each file under the terms given at the top of each file I changed.