Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.1.90 starts full re-embedding every time on start #729

Closed
alk0 opened this issue Aug 18, 2024 · 6 comments
Closed

2.1.90 starts full re-embedding every time on start #729

alk0 opened this issue Aug 18, 2024 · 6 comments

Comments

@alk0
Copy link

alk0 commented Aug 18, 2024

2.1.90 starts full re-embedding every time on start. Embeddings are saved to files, identical ones (as far as floating point values can be indentical) are added to the file over and over again, but never used. Hash values for duplicate records are the same. On the next start new embeddings for notes are computed and saved again. This leads to huge time and/or cost expenses.

Steps to reproduce:

  1. Create a clean new vault (containing the default Welcome.md note)
  2. Install smart-connections (with the default BGE-micro-v2 embedding model)
  3. Close and open the vault a few times

Results:

  • Embeddings are re-calculated on each load, AJSON files get new "SmartSource:" records added every time. No errors reported in the console.

Expected behavior:

  • Embeddings for the same (content hash, model, settings) are never re-calculated

Example of such AJSON attached, zipped.
Welcome_md.zip

@palwoo
Copy link

palwoo commented Aug 18, 2024

Me too.

@3-ark
Copy link

3-ark commented Aug 18, 2024

Same

@brianpetro
Copy link
Owner

Looking into it 👀🌴

@brianpetro
Copy link
Owner

I narrowed down the issue, working on a fix.

Removing the preceding . in the Smart Connection Folder setting should prevent subsequent re-embeddings, as the issue only affects hidden folders. (Note: this will likely make the embeddings sync via Obsidian Sync and will also show the folder in your vault file explorer).

🌴

@brianpetro
Copy link
Owner

I implemented and shipped a fix in v2.1.92. Thanks @alk0 @palwoo & @3-ark for bringing this to my attention 😊🌴

@alk0
Copy link
Author

alk0 commented Aug 18, 2024

(After some testing) 2.1.92 seems to work for me. @brianpetro I don't mind if you close the issue, if there are no other objections.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants