Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New User: Chat based on personal notes not working #483

Open
XueliTian opened this issue Feb 27, 2024 · 15 comments
Open

New User: Chat based on personal notes not working #483

XueliTian opened this issue Feb 27, 2024 · 15 comments

Comments

@XueliTian
Copy link

Firstly, thanks for making this great product. I am a heavy Obsidian User in Data & AI area, thinking of making an Obsidian Plugin and then found this one. Great work!

Most of the features working fine after a long waiting of embedding - I can get good similar file recommendation through Smart Connections Files and regular chat response through Smart Connections Chat. However, when I began using prompting like "Based on my notes" to trigger personally chat experience, it failed working. Here is the screenshot of developer console

image

And here is my settings

  • Notes Embedding Model: Open AI Text-3 Small (API, 8,191 tokens, 1,536 dim)
  • Blocks Embedding Model: None
  • Smart Chat Model: gpt-3.5-turbo (16k)
  • Included files: 1604
  • size of smart_notes-text-embedding-3-small.ajson: 30M
  • Machine: Mac Mini M1 8GB
@brianpetro
Copy link
Owner

Hey @XueliTian

First, I'm happy you found Smart Connections, and I'm sorry you're running into this issue!

  1. Let's toggle on this setting to improve the logs in the developer console (this setting makes the line numbers match the original code rather than the compiled code).
    Screenshot 2024-02-27 at 6 13 25 PM

  2. Restart Obsidian: this might solve the issue if Smart Connections has been updated since the last time you restarted Obsidian. The error in the screenshot points to a new method that was introduced in the last update, and I've noticed that something seems like old/additional plugin instances hang around longer than one would expect, so a restart just might solve it.

  3. After the restart, please try the chat again with some retrieval-triggering chat query like Based on my notes, who am I? and then screenshot any errors in the logs just like before.

Lastly, thanks for providing a detailed report with screenshots!

🌴

@destiny911
Copy link

destiny911 commented Feb 28, 2024

I am having the same issue.

image

I closed and restarted and tested the same.
I've never used the developer console before - so not sure what to look for but here are some errors it is pointing out.

image

@adrm
Copy link

adrm commented Feb 28, 2024

Same here, I was already using smart connections but since the update to 2.0, and after processing my notes with the new local models, the chat always tells me it doesn't have access to my notes. I've also tried with the OpenAI models, but the response is the same.

@XueliTian
Copy link
Author

@brianpetro Thanks for your quick reply, here is the full screenshot

image

@brianpetro
Copy link
Owner

@XueliTian thanks!

Can you also screenshot your settings for me?

I'm still wondering what might be causing this, so any additional information will be helpful.

🌴

@XueliTian
Copy link
Author

@brianpetro Sure thing. Let me know if there is any other particular setting you are interested in

image

image

@brianpetro
Copy link
Owner

@XueliTian Thanks! Those settings were what I needed.

This only happens when block-level embeddings are set to none.

That will help me get this fixed ASAP.

Thanks for your help!

🌴

@brianpetro
Copy link
Owner

@XueliTian @destiny911 @adrm This should be fixed with the latest update, v2.0.122

🌴

@adrm
Copy link

adrm commented Feb 28, 2024

I just updated, force refreshed the embeddings, relaunched obsidian... and the smart connections chat still tells me it doesn't have access to my notes even when I ask in different ways. This worked perfectly before and it was my mostly used feature for this plugin. Is there some way I can help you debug and fix this? Thank you!

@brianpetro brianpetro reopened this Feb 28, 2024
@brianpetro
Copy link
Owner

@adrm thanks for following up. And yes!

Please screenshot the developer console after trying to use the chat.

See #483 (comment) for example

The logs there might help me figure out if something else is happening.

Similarly, a screenshot of your settings will also allow me to make sure I trying out the right variation of settings in my testing.

Thanks for your help in solving this!

🌴

@XueliTian
Copy link
Author

@brianpetro I can confirm this update fixed my problem! Thank you so much for the quick fix!

@brianpetro
Copy link
Owner

@XueliTian thanks for letting me know!

@destiny911
Copy link

Updated plugin, restarted Obsidian and still was not working for me. I went into settings and changed the Notes Embedding Model from None to BGE watched it embed and it seems to be working for me now with the setting change.

@Frekido
Copy link

Frekido commented Mar 1, 2024

Same problem here, with the latest version when trying to chat the same message "the note explains that after configuring.... Once processing is complete..."

@Frekido
Copy link

Frekido commented Mar 1, 2024

Scherm­afbeelding 2024-03-01 om 09 27 20 Scherm­afbeelding 2024-03-01 om 09 27 29

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants