Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not populating links #12

Closed
arminta7 opened this issue Jan 10, 2023 · 10 comments
Closed

Not populating links #12

arminta7 opened this issue Jan 10, 2023 · 10 comments

Comments

@arminta7
Copy link

Getting this in the logs

Screenshot 2023-01-09 at 19 42 16

@brianpetro
Copy link
Owner

The loud/breaking part of that error is fixed by ensuring the downstream code can handle errors from the OpenAI API.

However, that still doesn't explain why you're getting 400 errors in the first place, so I added the exact response from OpenAI to the console log when this occurs. This way, if you see 400 errors, we should also see a response object from OpenAI, which may give us more insight into what's happening.

This was referenced Jan 10, 2023
@arminta7
Copy link
Author

This was working again until the recent update 1.0.31 now I'm getting this:
Screenshot 2023-01-10 at 16 11 47

brianpetro added a commit that referenced this issue Jan 10, 2023
@brianpetro
Copy link
Owner

Thanks for this!

1.0.31 included developments that should decrease total token usage. But, I didn't want to require refreshing all embeddings right away, so embeddings start to use the improved storage strategy gradually. This bug was at the intersection of those two strategies.

And thanks for the always speedy updates! 😊

@brianpetro
Copy link
Owner

Oh, forgot to mention that 1.0.32 should've fixed the above issue, too.

@arminta7
Copy link
Author

Still not working after the update. Looks like the same error.

brianpetro added a commit that referenced this issue Jan 11, 2023
@brianpetro
Copy link
Owner

I just added the last thing I could think of for the last error you screenshotted.

PS- the screenshots are a real big help, thanks!

@arminta7
Copy link
Author

Links are working now! 🎉

Still getting the 400 errors in the logs, which is fine as long as I can get rid of these popups (they happen every time I navigate to a new page) I can open a new issue for this if that's better.

Screenshot 2023-01-10 at 19 39 37

Thanks for addressing everything so quickly!

brianpetro added a commit that referenced this issue Jan 11, 2023
@arminta7
Copy link
Author

All better! Thank you!

@brianpetro
Copy link
Owner

OpenAI Error notification muted :)

But I'm stumped about what to do with those 400 errors. I think there might be a character encoding issue. I recently reduced the maximum character length per embedding, which would have at least reduced the number of these errors if input size was the issue (input greater than max tokens).

@brianpetro
Copy link
Owner

Moving discussion about 400 errors to #10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants